Mathew Polzin

Results 223 comments of Mathew Polzin

Would the `MetaRelationship` type described [here](https://github.com/mattpolzin/JSONAPI/blob/main/documentation/usage.md#jsonapirelationships) work for your use-case?

I'm not totally ruling out the option you've coded up here, because it does feel like a very appropriate use-case, but I am hesitant to make this change because it...

I can think of two other options: - Add a singleton static configuration type a la https://github.com/mattpolzin/OpenAPIKit/blob/release/3_0/Sources/OpenAPIKit/CodableVendorExtendable.swift#L24 - Support a new static function on the `Relationships` protocol that returns a...

Getting back to this because I'd like to get it merged. I realized my last comment may have been ambiguous (did I want you to make the change or would...

Yeah, this would be nice. Are you referring to Fluent models in particular or models that are represented as plain Swift structs?

Do your DTOs encode to JSON pretty directly or do they use Swift features like property wrappers? If you'd be able to share an example of a DTO you use,...

It looks like you've got `ActivityLog.Public` set up to render in OpenAPI documentation; am I reading your above comments correctly that you do have some glue code that currently adds...

What I am wondering is if you could possibly only need to add `OpenAPIEncodedSchema` conformance to your `ActivityLog` type (by just calling to `ActivityLog.Public`'s existing conformance).

To give my thought some context, if your `Vapor.Route` has a response type of `ActivityLog`, then your response body schema will get picked up by https://github.com/mattpolzin/VaporOpenAPI/blob/main/Sources/VaporOpenAPI/VaporRoute%2BOpenAPI.swift#L263 if your `ActivityLog` type...

If, by some chance, the `DTO` protocol dictates that there exists a nested `Public` type, you could probably even write an `extension DTO: OpenAPIEncodedSchemaType where Public: OpenAPIEncodedSchemaType` to save some...