xstate-codegen icon indicating copy to clipboard operation
xstate-codegen copied to clipboard

Fix babel plugin macros use in machines

Open danielkcz opened this issue 3 years ago • 3 comments

I've noticed there is some attempt in code to make macros working, but no testable example so far. So I've added one and it doesn't seem to work. I have no idea what to do about it. If you can give me hint, I can try to fix it.

image

Edit: Maybe I am misunderstanding what that piece of code does, but simply adding babel-plugin-macros to the list did not solve the problem.

danielkcz avatar Oct 09 '20 04:10 danielkcz

🦋 Changeset detected

Latest commit: 9d50e15325335650eb65d1adab38f1a675bbf694

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate-codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 09 '20 04:10 changeset-bot[bot]

@mattpocock This is the last piece (for now) for me to fully convert to codegen. I know I could do without macros, but that's too verbose :) I would appreciate some help, I have no idea what's happening there.

danielkcz avatar Oct 11 '20 07:10 danielkcz

Hah, new year = new brain. I just added babel-plugin-macros to the mix and it solves this. It's ready for merge.

danielkcz avatar Jan 07 '21 10:01 danielkcz