xstate-catalogue icon indicating copy to clipboard operation
xstate-catalogue copied to clipboard

Video/Audio Machine

Open leonardomso opened this issue 3 years ago • 4 comments

As discussed in the #47 issue, here's the pull request for the Video/Audio controls machine.

I still think there's a lot of room for improvement in this machine. I'd love to receive some feedback.

A few ideas that I think could be discussed:

  • Change the initial state of ready state for idle. There might be some use cases where people want to load the content but not auto-play it.
  • Add support for seek.
  • Add support for quality controls and subtitles as @mattpocock suggested.

leonardomso avatar May 27 '21 17:05 leonardomso

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mattpocock/xstate-catalogue/6jGjaLLpu8hsRMs8cQeYRdQDpqd2
✅ Preview: https://xstate-catalogue-git-fork-leonardomso-master-mattpocock.vercel.app

vercel[bot] avatar May 27 '21 18:05 vercel[bot]

Thanks! Should the discussion be in this PR thread, or back in the Issue?

tomByrer avatar May 30 '21 01:05 tomByrer

I think it would be fine if it was in this pull request. What are your thoughts about it so far, @tomByrer?

leonardomso avatar Jun 08 '21 13:06 leonardomso

What are your thoughts of putting the boolean context items in parallel states, as in https://xstate.js.org/viz/?gist=b9a8e4db654cea07fe2080bd56b6cdc7

christianchown avatar Sep 09 '21 11:09 christianchown