jest-expect-message icon indicating copy to clipboard operation
jest-expect-message copied to clipboard

fixing issue #39

Open alexneo2003 opened this issue 3 years ago • 26 comments

fixing issue #39 support jest >= 27

alexneo2003 avatar Jun 09 '21 15:06 alexneo2003

@mattphillips can you review PR

alexneo2003 avatar Jun 13 '21 18:06 alexneo2003

oh man it will be so nice this can be in :D

adamchenwei avatar Jun 14 '21 22:06 adamchenwei

+1

Shakes03 avatar Jun 16 '21 19:06 Shakes03

I'm also having the same issue, can this be merged please?

golergka avatar Jun 21 '21 06:06 golergka

For now, jest-expect-message breaks all my build/check pipelines. @alexneo2003 seen that the repo owner @mattphillips seems too busy to merge this right now (I totally get it, he got a life and a job), would it be possible for you to build the package & commit + push built artifacts on github out of this PR ? I won't ask for support, I just want my CI to stop yelling at me :sob: .

In the meantime, I've temporarily solved the problem this way:

npm i -D https://github.com/alexneo2003/jest-expect-message#issue-39
cd ./node_modules/jest-expect-message
npm i
npm run build
cd ../../

It is also possible to automate the build so that it is not removed after npm install by adding a script in package.json:

// ...
    "postinstall": "cd ./node_modules/jest-expect-message && npm i && npm run build && cd ../../",
// ...

:beers: cheers

GerkinDev avatar Jun 21 '21 13:06 GerkinDev

@GerkinDev @golergka @Shakes03 @adamchenwei @beatrichartz @jkoenig134 @ambroselittle i'm publishing package @alex_neo/jest-expect-message check pls connect to project as

  setupFilesAfterEnv: ['@alex_neo/jest-expect-message'],

alexneo2003 avatar Jun 22 '21 07:06 alexneo2003

This is great, thank you.

Hope though that the original package owner will get some time to merge PRs

GerkinDev avatar Jun 22 '21 13:06 GerkinDev

@alexneo2003, confirmed works on mine. thank you.

ambroselittle avatar Jun 24 '21 20:06 ambroselittle

@mattphillips Is there any chance that this can get merged? Or how about moving it to https://github.com/orgs/jest-community so it doesn't rely on a single person?

Trainmaster avatar Aug 06 '21 16:08 Trainmaster

@mattphillips Is there any chance that this can get merged? Or how about moving it to https://github.com/orgs/jest-community so it doesn't rely on a single person?

Check this

alexneo2003 avatar Aug 06 '21 16:08 alexneo2003

@mattphillips - I know this has been mentioned a few times here already, but would love if this could get merged in if you have a chance! Thank you, and thank you @alexneo2003 for the fix!

gracepark avatar Aug 12 '21 21:08 gracepark

I also would like this to be merged @mattphillips thanks

DanKaplanSES avatar Aug 31 '21 03:08 DanKaplanSES

@jongio I noticed you are the other contributors of this repository. Do you have the ability to merge this feature in? Thanks!

DanKaplanSES avatar Aug 31 '21 03:08 DanKaplanSES

Sorry, I do not.

jongio avatar Aug 31 '21 18:08 jongio

I hit this issue today and would also like it to be merged. @mattphillips do you need any help?

wycats avatar Oct 14 '21 21:10 wycats

@mattphillips I suggest you add another maintainer. Jest 27 was released a good long while ago.

jcollum avatar Oct 15 '21 18:10 jcollum

How to skip such type of warnings?

ts-jest[ts-compiler] (WARN) test/e2e/example.e2e.ts:110:19 - error TS2554: Expected 1 arguments, but got 2.

orihomie avatar Oct 26 '21 08:10 orihomie

What would you think about giving the Jest community a nice Christmas gift, @mattphillips ? 🎄🙏😁

rinogo avatar Dec 30 '21 01:12 rinogo

I think this highlights why this functionality should've been part of core from the beginning.

phawxby avatar Jan 11 '22 20:01 phawxby

My 2 cents mean little here, but this is a good fix and retains backwards-compatibility.

I will note for others that I found jest-chain has a similar issue where one of the commenters suggests using the patch-package project.

KosnIre avatar Jan 15 '22 03:01 KosnIre

@mattphillips hello?

slavafomin avatar Mar 15 '22 16:03 slavafomin

@jongio do you have any ability to add maintainers? It's been almost 6 months since I pinged Matt Phillips about this and 9 months since this ticket was opened.

jcollum avatar Mar 15 '22 18:03 jcollum

No sorry.

jongio avatar Mar 15 '22 19:03 jongio

Please. There must be a way we can merge this.

thephilwells avatar Apr 19 '22 14:04 thephilwells

https://twitter.com/jongallant/status/1516437398032244738

jongio avatar Apr 19 '22 15:04 jongio

Since this hasn't been fixed in a year, I've gone ahead and published a new version of the package: jest-27-expect-message.

I'll mark this package as deprecated if the official jest-expect-message is ever updated

https://www.npmjs.com/package/jest-27-expect-message

HumbertoL avatar May 16 '22 14:05 HumbertoL

Sorry for the delay. Thanks for the fix @alexneo2003

mattphillips avatar Sep 08 '22 15:09 mattphillips

Fix is available in: https://www.npmjs.com/package/jest-expect-message/v/1.0.4

mattphillips avatar Sep 08 '22 17:09 mattphillips