jest-chain icon indicating copy to clipboard operation
jest-chain copied to clipboard

throw error if it isn't a match error

Open tonivj5 opened this issue 4 years ago β€’ 4 comments

What

Simply throw error if it isn't a match error

Why

https://github.com/mattphillips/jest-chain/issues/22

Notes

Housekeeping

  • [ ] Unit tests
  • [ ] Documentation is up to date
  • [ ] No additional lint warnings

tonivj5 avatar Mar 03 '20 19:03 tonivj5

Codecov Report

Merging #24 into master will decrease coverage by 4%. The diff coverage is 66.66%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #24   +/-   ##
====================================
- Coverage     100%   96%   -4%     
====================================
  Files           2     2           
  Lines          23    25    +2     
  Branches        3     4    +1     
====================================
+ Hits           23    24    +1     
- Misses          0     1    +1
Impacted Files Coverage Ξ”
src/chain.js 95.83% <66.66%> (-4.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update dde0129...d0585ca. Read the comment docs.

codecov-io avatar Mar 03 '20 19:03 codecov-io

I will add tests if there's intention to merge it :sweat_smile:

tonivj5 avatar Mar 03 '20 19:03 tonivj5

Can we merge this?

abhijit945 avatar Oct 25 '20 21:10 abhijit945

Is this repo dead? Why is this not actively being looked at. It is a huge blocker to using jest-chain

MatthewPardini avatar Oct 20 '21 16:10 MatthewPardini

Sorry for the delay in coming to this!! This issue has now actually been fixed in: https://www.npmjs.com/package/jest-chain/v/1.1.6

mattphillips avatar Sep 28 '22 16:09 mattphillips