MeanShift_py icon indicating copy to clipboard operation
MeanShift_py copied to clipboard

Absolute imports or PIP package?

Open jembezmamy opened this issue 6 years ago • 1 comments

Hi,

I don't use Python on regular basis, so maybe I don't understand something here, but how exactly am I supposed to include your code in my project? Usually I load stuff with PIP, but it seems that you haven't publish PIP package for this repo.

So I tried using git submodule and it seems ok, but I've got a problem with absolute imports - I use Python 3 so statements like import point_grouper as pg won't work unless I include your code in my project root directory - which would be so hacky. :smile:

I think this could by fixed by replacing import lines with something like from . import point_grouper as pg. What do you think about this?

I feel that PIP package would be more elegant solution.

jembezmamy avatar Jun 04 '18 19:06 jembezmamy

This is a great point. Sorry for responding a year and a half late. I'm not really able to actively maintain this repo or respond to issues very well. I'll see if I'm able to turn this into a package.

mattnedrich avatar Nov 28 '19 15:11 mattnedrich