go-sqlite3
go-sqlite3 copied to clipboard
port sqlcipher to go-sqlite3
hi mattn: I ported sqlcipher to go-sqlite3 and just made it work, I knew that the PR is mess up, here are what i did:
- port sqlcipher from 3.20 to 3.24, put it in sqlite3-binding.c
- put libtomcrypt files in (just for easy building)
- port your see branch back
- some readme modification for people just want make it work quickly
- modify _example/simple just for testing if it works
I don't know weather you are willing to add this feature. if it is, I will do some clean up and make the PR decent. here is a list i am willing to do, and any advise is welcome :)
- make a patch for sqlite3-binding.c, add it to upgrade package
- make the crypto lib out side the project
- put openssl and commoncrypt support back, maybe
- make a build tag for enabling the crypto codec
- more tests
- cleanup the garbage commits
Coverage decreased (-0.01%) to 58.154% when pulling 9bf2a8ae53435df18b8967217b5beccd8e602ed6 on CovenantSQL:master into 3198c7714d5f8be941dd06c30208e623aa5abf90 on mattn:master.
You have better to work on $GOPATH/src/github.com/mattn/go-sqlite3 with branch not on $GOPATH/src/github.com/CovenantSQL/go-sqlite3-encrypt.
@GJRTimmer How do you think this PR?
FYI https://github.com/xeodou/go-sqlcipher is basically what is described in this PR (I can't speak for the code though, haven't read it)
any progress ?
@GJRTimmer How do you think this PR?
Looking into it
Any updates?
I have created the following PR to allow using SQLCipher with go-sqlite3, which I believe supersedes this one: https://github.com/mattn/go-sqlite3/pull/1109