go-sqlite3 icon indicating copy to clipboard operation
go-sqlite3 copied to clipboard

port sqlcipher to go-sqlite3

Open auxten opened this issue 5 years ago • 9 comments

hi mattn: I ported sqlcipher to go-sqlite3 and just made it work, I knew that the PR is mess up, here are what i did:

  1. port sqlcipher from 3.20 to 3.24, put it in sqlite3-binding.c
  2. put libtomcrypt files in (just for easy building)
  3. port your see branch back
  4. some readme modification for people just want make it work quickly
  5. modify _example/simple just for testing if it works

I don't know weather you are willing to add this feature. if it is, I will do some clean up and make the PR decent. here is a list i am willing to do, and any advise is welcome :)

  1. make a patch for sqlite3-binding.c, add it to upgrade package
  2. make the crypto lib out side the project
  3. put openssl and commoncrypt support back, maybe
  4. make a build tag for enabling the crypto codec
  5. more tests
  6. cleanup the garbage commits

auxten avatar Aug 24 '18 04:08 auxten

Coverage Status

Coverage decreased (-0.01%) to 58.154% when pulling 9bf2a8ae53435df18b8967217b5beccd8e602ed6 on CovenantSQL:master into 3198c7714d5f8be941dd06c30208e623aa5abf90 on mattn:master.

coveralls avatar Aug 24 '18 04:08 coveralls

You have better to work on $GOPATH/src/github.com/mattn/go-sqlite3 with branch not on $GOPATH/src/github.com/CovenantSQL/go-sqlite3-encrypt.

mattn avatar Aug 30 '18 04:08 mattn

@GJRTimmer How do you think this PR?

mattn avatar Aug 30 '18 10:08 mattn

FYI https://github.com/xeodou/go-sqlcipher is basically what is described in this PR (I can't speak for the code though, haven't read it)

skaufman-socialflow avatar Sep 24 '18 20:09 skaufman-socialflow

any progress ?

lewgun avatar Mar 17 '19 07:03 lewgun

any progress ?

you can just use my fork version.

auxten avatar Mar 18 '19 01:03 auxten

@GJRTimmer How do you think this PR?

Looking into it

gjrtimmer avatar Aug 21 '19 19:08 gjrtimmer

Any updates?

joyciep avatar Feb 21 '20 02:02 joyciep

I have created the following PR to allow using SQLCipher with go-sqlite3, which I believe supersedes this one: https://github.com/mattn/go-sqlite3/pull/1109

jgiannuzzi avatar Nov 22 '22 15:11 jgiannuzzi