go-mastodon icon indicating copy to clipboard operation
go-mastodon copied to clipboard

Add method to include accounts resolve param

Open paultyng opened this issue 2 years ago • 4 comments

Unsure what is the preferred way to add params that aren't currently exposed. Would you prefer a variadic parameter with modifiers or something, or just add additional methods like this? There is another param missing but I didn't need it for my usecase: following: https://docs.joinmastodon.org/methods/accounts/

paultyng avatar Nov 07 '22 15:11 paultyng

Could you please add test?

mattn avatar Nov 08 '22 15:11 mattn

Codecov Report

Base: 87.16% // Head: 87.28% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (f610598) compared to base (7dfe81e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   87.16%   87.28%   +0.12%     
==========================================
  Files          15       15              
  Lines         935      944       +9     
==========================================
+ Hits          815      824       +9     
  Misses         75       75              
  Partials       45       45              
Impacted Files Coverage Δ
accounts.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Nov 16 '22 22:11 codecov-commenter

Sorry, test already exists.

mattn avatar Nov 29 '22 23:11 mattn

Could you please fix conflicts?

mattn avatar Nov 30 '22 17:11 mattn