go-isatty
go-isatty copied to clipboard
Adjust build tags to allow building on tinygo; for #73.
Passes "tinygo test" on macos and linux. Passes cross test to windows from macos, i.e. "GOOS=windows tinygo test -c; wine64 go-isatty.test".
Had to adjust the build tags on isatty_others.go to avoid multiple definition link failure on
$ GOOS=windows tinygo test
Codecov Report
Merging #74 (9bb614f) into master (cdb00f1) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 44.00% 44.00%
=======================================
Files 3 3
Lines 75 75
=======================================
Hits 33 33
Misses 40 40
Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| isatty_bsd.go | 100.00% <ø> (ø) |
|
| isatty_tcgets.go | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update cdb00f1...9bb614f. Read the comment docs.
Hi @mattn
is it possible to get this merged so that we can use this with tinygo?
could you please fix conflict?
Hi @dkegel-fastly thank you for fixing the conflict.
@mattn over to you now :), thank you so much.
Hi @mattn , a kind reminder. thank you.
a kind reminder @mattn, thank you.
Hi @mattn , a kind reminder to kindly review the PR. once merged, it will allow folks, using tinygo, to stop using the fork.
many thanks in advance.
Yes, please!
tinygo-0.28 is coming out shortly, which will bring more users hoping for this fix, I think!
Hi @mattn, another request to merge @dkegel-fastly’s PR. Ran into this issue today with TinyGo. Many thanks!
thanks