go-isatty icon indicating copy to clipboard operation
go-isatty copied to clipboard

Adjust build tags to allow building on tinygo; for #73.

Open dkegel-fastly opened this issue 3 years ago • 1 comments

Passes "tinygo test" on macos and linux. Passes cross test to windows from macos, i.e. "GOOS=windows tinygo test -c; wine64 go-isatty.test".

Had to adjust the build tags on isatty_others.go to avoid multiple definition link failure on

$ GOOS=windows tinygo test

dkegel-fastly avatar Jun 19 '22 18:06 dkegel-fastly

Codecov Report

Merging #74 (9bb614f) into master (cdb00f1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files           3        3           
  Lines          75       75           
=======================================
  Hits           33       33           
  Misses         40       40           
  Partials        2        2           
Impacted Files Coverage Δ
isatty_bsd.go 100.00% <ø> (ø)
isatty_tcgets.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdb00f1...9bb614f. Read the comment docs.

codecov-commenter avatar Jun 28 '22 00:06 codecov-commenter

Hi @mattn

is it possible to get this merged so that we can use this with tinygo?

rajatjindal avatar May 20 '23 06:05 rajatjindal

could you please fix conflict?

mattn avatar May 20 '23 10:05 mattn

Hi @dkegel-fastly thank you for fixing the conflict.

@mattn over to you now :), thank you so much.

rajatjindal avatar May 20 '23 17:05 rajatjindal

Hi @mattn , a kind reminder. thank you.

rajatjindal avatar May 24 '23 06:05 rajatjindal

a kind reminder @mattn, thank you.

rajatjindal avatar Jun 04 '23 02:06 rajatjindal

Hi @mattn , a kind reminder to kindly review the PR. once merged, it will allow folks, using tinygo, to stop using the fork.

many thanks in advance.

rajatjindal avatar Jun 09 '23 19:06 rajatjindal

Yes, please!

dkegel-fastly avatar Jun 09 '23 20:06 dkegel-fastly

tinygo-0.28 is coming out shortly, which will bring more users hoping for this fix, I think!

dkegel-fastly avatar Jun 09 '23 20:06 dkegel-fastly

Hi @mattn, another request to merge @dkegel-fastly’s PR. Ran into this issue today with TinyGo. Many thanks!

ydnar avatar Oct 17 '23 05:10 ydnar

thanks

mattn avatar Oct 17 '23 07:10 mattn