vue-beautiful-chat icon indicating copy to clipboard operation
vue-beautiful-chat copied to clipboard

Compare author against id instead of 'me'

Open MaeseppTarvo opened this issue 5 years ago • 6 comments

If backward-compability is needed then we gotta do some checks and make authorID not required. Right now there is new prop needed, authorId which is current user id.

MaeseppTarvo avatar Sep 06 '19 07:09 MaeseppTarvo

I think we should keep backward compatibility and release this feature. At the moment I don't have that many active collaborators to be able to start working on a version 3.

I will definitely organize the issues and assess what needs to be included and when would be a right moment to start working on v3.

Thanks for this PR and let me know if you can take care of the backward compatibility.

Cheers.

mattmezza avatar Sep 06 '19 11:09 mattmezza

Hi, Do you have an estimation or an delay for this feature because i would like use this feature too. Thanks best

arabakevin avatar Dec 30 '19 23:12 arabakevin

An easy fix for backwards compatibility would be to add a default value?

authorId: {
  type: String,
  required: false,
  default: 'me'
}

This is a great feature and would help us quite a bit.

j-tegen avatar Jan 03 '20 14:01 j-tegen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 13 '20 10:06 stale[bot]

Will be tackled in #194 thanks for the idea :) 👍

mattmezza avatar Oct 18 '20 20:10 mattmezza

@mattmezza I think we should include this as a separate thing as it'll be much quicker than tackling that huge PR (and it will make #194 simpler, too, I think). The authorId will be put in the store so I'll update this PR.

a-kriya avatar May 18 '21 18:05 a-kriya