Matt McDermott

Results 40 comments of Matt McDermott

Excellent write-up! @utf I agree -- if the schema construction approach is used, this shouldn't be too much extra work to implement for a developer. My original hesitation with writing...

Thanks! Yes feedback especially on schemas would be useful -- I did base them on your previous sketches though.

FYI: I moved the builder into `common`. Of course, this opens up the possibility of the builder mixing outputs from different DFT codes; I addressed this by adding a property...

Btw I haven't forgotten about this; just a little preoccupied. Need to address a bug still and write tests!

Bug was addressed. See Issue #505 where AFM orderings were being destroyed between relax and static calcs. Fix was provided in PR #506. Still need to write tests and then...

@utf I just implemented your suggestion in #466. This workflow now contains a postprocessing job that shares much of the doc-constructing code used in the builder. In addition to feedback...

Test for magnetic ordering workflow has been added (using the developer guide). Since writing this code, @mcgalcode and I have also run the workflow and builder on 50+ structures, and...

Hi @Zhuoying, thanks for the nice feedback and code review; this is very helpful! > The remaining issue might be: (i) Is the default incar settings (EDIFF=1e-5) in StaticMaker sufficient...

1. @Zhuoying and @JaGeo Thank you for the helpful discussion on EDIFF values. I agree with your assessment and will implement `EDIFF=1e-7` as the new default. 2. @Zhuoying Regarding the...

I added support for `enumlib` installation during testing with Github Actions per the commands used in the pymatgen github workflows. Adds about 30s to the testing run; hopefully this is...