react-simple-auth icon indicating copy to clipboard operation
react-simple-auth copied to clipboard

fix(checkWindow): Handle the case where popup windows are blocked in the browser

Open artptr opened this issue 5 years ago • 2 comments

window.open returns null if the window couldn't be opened.

artptr avatar Jan 10 '20 09:01 artptr

Coverage Status

Coverage increased (+0.3%) to 94.318% when pulling 713487a922fcc4018d180df1d103dc6f2c2ef5ec on artptr:fix-null-window into 76dae5c8b0033678e4347de302b4664541949505 on mattmazzola:master.

coveralls avatar Jan 10 '20 09:01 coveralls

BTW I have no idea why commit-lint rejects my commit message. I tried to make it using git-cz.

artptr avatar Jan 10 '20 10:01 artptr