Pterodactyl4J icon indicating copy to clipboard operation
Pterodactyl4J copied to clipboard

RateLimiter removes request from queue on failure

Open BelgianDev opened this issue 1 year ago • 3 comments

Added finally block to the try catch of the RateLimiter#run() and moved the iterator.remove() call to the finally block

BelgianDev avatar Jan 12 '24 14:01 BelgianDev

Any updates on this pr?

BelgianDev avatar Apr 07 '24 15:04 BelgianDev

i think the thing to do here would be to validate the url inside of the endpoint config rather than removing the request from the ratelimiter (here should work). the reason this doesn't look like it works as expected is because it's never reaching the part where retry backoff is supposed to occur

mattmalec avatar Apr 07 '24 16:04 mattmalec

@mattmalec Here are the changes you requested, I reverted my last changes and added URL validation using a Regex

BelgianDev avatar Apr 09 '24 16:04 BelgianDev