Pterodactyl4J icon indicating copy to clipboard operation
Pterodactyl4J copied to clipboard

Published 20 hours ago • verified publisher icon mattmalec

Feature: Node: setMaintanceMode

Open DerMistkaefer opened this issue 1 year ago • 4 comments

This PR introduces the functionality to set a Node into Maintenance Mode.

API Doc: https://dashflo.net/docs/api/pterodactyl/v1/ image

DerMistkaefer avatar Dec 27 '23 17:12 DerMistkaefer

Personally I would change hasMaintanceMode into isInMaintenanceMode or inMaintenanceMode or something like that

lokerhp avatar Dec 28 '23 09:12 lokerhp

Thank you for your suggestion regarding the naming convention. Based on your feedback, I have updated the property to a more descriptive name, isInMaintenanceMode. However, I have decided to keep the function name as setMaintanceMode to maintain consistency with the existing getter hasMaintanceMode, as referenced in Entity Node L45. This balance allows us to improve clarity while preserving coherence in our codebase.

DerMistkaefer avatar Jan 01 '24 16:01 DerMistkaefer

Thank you for your feedback. I don't want to change the old function name but when you say it is okay then let's go. Now we use correct naming.

DerMistkaefer avatar Jan 02 '24 17:01 DerMistkaefer

@mattmalec can we please merge this?

DerMistkaefer avatar Jan 13 '24 12:01 DerMistkaefer