FASwiftUI icon indicating copy to clipboard operation
FASwiftUI copied to clipboard

Draft: remove support for v5

Open heyjones opened this issue 2 years ago • 4 comments

  • icons.json has been deprecated in favor of icons-families.json
  • i couldn't find a way to swap these out without breaking backwards compatibility

heyjones avatar Oct 06 '23 22:10 heyjones

Interesting. Could make v3 require FA6. How different is the new json file?

mattmaddux avatar Oct 06 '23 22:10 mattmaddux

Not sure exactly, but there’s another font that v5 doesn’t support and figured it might be better to just have a version that fully supports v6 unless there’s an easy way to continue to support both?

On Fri, Oct 6, 2023 at 3:37 PM Matt Maddux @.***> wrote:

Interesting. Could make v3 require FA6. How different is the new json file?

— Reply to this email directly, view it on GitHub https://github.com/mattmaddux/FASwiftUI/pull/23#issuecomment-1751471909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESWG77IWBDXYL6QEAJMHTX6CB4FAVCNFSM6AAAAAA5WM22V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGQ3TCOJQHE . You are receiving this because you authored the thread.Message ID: @.***>

heyjones avatar Oct 06 '23 22:10 heyjones

Will try to look into it this weekend and see what I think. I've also been wanting to change how it processes the json file. Doing at at runtime isn't really ideal and I'd like to investigate how the new Swift macro features might enable it to be pushed to compile-time.

A new file-format might mean it's the right time.

mattmaddux avatar Oct 06 '23 22:10 mattmaddux

That sounds amazing! My app dev was mentioning some performance improvements that could be made.

On Fri, Oct 6, 2023 at 3:48 PM Matt Maddux @.***> wrote:

Will try to look into it this weekend and see what I think. I've also been wanting to change how it processes the json file. Doing at at runtime isn't really ideal and I'd like to investigate how the new Swift macro features might enable it to be pushed to compile-time.

A new file-format might mean it's the right time.

— Reply to this email directly, view it on GitHub https://github.com/mattmaddux/FASwiftUI/pull/23#issuecomment-1751477799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESWG55UJPWT6ZQLCTFVZDX6CDDLAVCNFSM6AAAAAA5WM22V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGQ3TONZZHE . You are receiving this because you authored the thread.Message ID: @.***>

heyjones avatar Oct 06 '23 22:10 heyjones