Matt Krick

Readme best practices: Where to put styles?

19

Something I'd like to see in the readme is where to put the styles. I see them above & below for the examples, but on a pretty large project (like...

throw when cert is null

2

Related to: https://github.com/tngan/samlify/issues/222 I had a case where our saved IdP cert was invalid & when the correct cert came back in the response the cert was null. The error...

 in my app i have text inside the cards & cards will get added & removed in real time, so i'd like to minimize the amount of shuffling. from...

Match standardjs for object-curly

3

standardjs allows spaces or no spaces for object-curlies (https://github.com/standard/eslint-config-standard/blob/master/eslintrc.json#L202). Would it be possible to follow suit for this, too?

fix for newer node versions

1

node now guarantees that the errorno is numeric: https://github.com/nodejs/node/commit/1432065e9dc77218507f328b63cb7f5d279dd6e9 since that enum could change, let's just check the code. keep the old errono for backwards compat This PR contains a:...

Object.create doesn't assign anything to the prototype. There are 2 workarounds for this: Option 1 use `new` (technically, this is faster since V8 optimizes for it, but used so infrequently...

Speed up repoIntegrations query

7

I want to get #5883 merged, but we need to fix the logic soon to keep the app feeling snappy. This is high priority because #5883 will introduce a much...

fix(noImplicitAny): Fixup 200 ts rules (Part 1 of 2)

1

# Description Fixes/Partially Fixes #7148 fixes a couple hundred `noImplicitAny` rules. The rest are fixed in #7193 ## Testing scenarios run `yarn tsc --noEmit -p tsconfig.noImplicitAny.json` and see that all...

feat: user presence supports k8s

1

# Description fix #7204 User presence is currently reset during a `postDeploy` step. This won't work when we move to k8s and have multiple servers deploying at different times. This...

feat(k8s): Flush redis Presence on shutdown

1

AC - [ ] when node receives the shutdown signal, it calls redis to remove all user presence for users connected to that SERVER_ID - [ ] remove the chunk...