Matt Krick
Matt Krick
@xymostech agreed, no need to tell folks how to write their code, maybe instead of best practices just a few popular options. This is something that affects the broader inline-styles...
@kentcdodds I think your option of using a static makes the most sense (for both functional and class components, as we saw with @xymostech's radio widget). It follows basic linting...
@kentcdodds go on. can you give me a little detail about shared styles? you'd build certain objects representing CSS classes & import those from multiple components? That seems really intriguing,...
@kentcdodds oh that's fantastic! I was thinking of sharing a POJOs & putting that into my `StyleSheet.create`, but you are sharing the the output of `StyleSheet.create`. :+1: Maybe the result...
@zgotsch @abhiaiyer91 do you guys use aphrodite for fonts by chance? Here's what I found: - Every time aphrodite adds something to the style tag, the entire tag must be...
@abhiaiyer91 I'm working on a PR right now to fix this, although it's closer to a rewrite & has breaking changes, so I'm not sure it'll get merged. Here's the...
@jlfwong here's the easiest way to see it: - open chrome dev console >> network tab >> Font - https://action-staging.parabol.co - log in: username: [email protected], password: 123123 - look at...
@abhiaiyer91 true true, while fonts are by _far_ the most expensive thing to re-evaluate, reparsing and re-evaluating the style tag for every new style isn't a sustainable path for a...
@chendo a fix is coming soon! If you can, please go ahead & add this to your dependencies in package.json: `"aphrodite": "https://github.com/mattkrick/aphrodite/tarball/e6dfa5559cbc6adbb6b7c8b4c432c8024d14738c"` Then run `npm i`. This is a pretty...
@chendo ahhh yeah, you'll wanna build it after install. (cd node_modules/aphrodite && npm run build:main)