ACF-Conditional-Taxonomy-Rules icon indicating copy to clipboard operation
ACF-Conditional-Taxonomy-Rules copied to clipboard

Small issue on installing the plug

Open IlanVivanco opened this issue 7 years ago • 2 comments

Hi @mattkeys, first of all, great plug! It was exactly what I needed.

Just a small issue I noticed, when first installing the plug. I had some JS errors in the console not allowing to load the values properly: value_values was undefined and it couldn't get the id prop. image. I'm sorry I couldn't get the console error screen, but I can't replicate it again now. I debugged it and found that in /includes/field_group_conditional_taxonomy.js:72, $( '.conditional-rule-value', $rule ); got no results.

I solved it simply removing the taxonomy field (created prior installation) and adding it again. WP version: WordPress 4.8.4 ACF Pro version: Version 5.6.7

Hope this helps you to find the origin of the problem.

Tnx

IlanVivanco avatar Jan 16 '18 21:01 IlanVivanco

Ah yea I probably need to add some error checking there to make sure that value_values (what a bad name ..) is set before I try to access its id and text. In my test environment I wasn't working with any existing fields I suppose.

mattkeys avatar Jan 16 '18 21:01 mattkeys

Sounds reasonable ;)

The solution is very simple in case someone faces the same issue anyway.

IlanVivanco avatar Jan 16 '18 21:01 IlanVivanco