Matt Joyce

Results 91 comments of Matt Joyce

I have been looking at a few popular python packages, there quite a bit of diversity. However some themes emerge. * the use of pre-commit is widespread, as this can...

Reading [pre-commit Introduction](https://pre-commit.com/#intro) [PyPi Packaging Projects](https://packaging.python.org/en/latest/tutorials/packaging-projects/) [SetupTools - User Guide - PyProject config](https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html)

this also looks looks very manageable. [Flit - Stable](https://flit.pypa.io/en/stable/) This does not do the Build, it's just the Publish, but Firecrawl python-sdk is just a couple of files...

OK, I was able to put together a pyproject.toml, and tweak setup.py to pull version from __init__.py then use Python -m build works fine. This way build code does not...

Here's the pull request for the first step. [ Python-SDK transitional build setup for pyproject.toml #196 ](https://github.com/mendableai/firecrawl/pull/196)

So, then I think an approach could be. Code is written, commits made, merges accepted, etc Maintainer want to publish - updates __init__.py with new version 1.2.3 - commits -...

@rafaelsideguide That makes sense but there are couples thing to consider, and I'm not sure what the consequences are. 1. change version in init, check against current published versions, trigger...

put together a script to check versions... ``` (firecrawl) W:\firecrawl\apps\python-sdk>python check_version_has_incremented.py js ../js-sdk/firecrawl @mendable/firecrawl-js Local version: 0.0.22 Published version: 0.0.21 true (firecrawl) W:\firecrawl\apps\python-sdk>python check_version_has_incremented.py python ./firecrawl firecrawl-py Local version: 0.0.11...

yeah, sounds like a plan! Also: 1. Tests are applied on merge requests, so maintainers should see fails there. 2. the check verions test could be used to throw a...

Here you go : https://github.com/mendableai/firecrawl/pull/213