select-list-card icon indicating copy to clipboard operation
select-list-card copied to clipboard

Selection items in visual editor don't show text description

Open kuchel77 opened this issue 4 years ago • 8 comments

Checklist:

  • [x] I updated to the latest version available
  • [x] I cleared the cache of my browser

Release with the issue: v1.0.0 Last working release (if known):

Browser and Operating System:

Firefox (77.0.1) and Safari (v??) on MacOS Catalina

Description of problem: Screen Shot 2020-07-06 at 10 15 23 am Screen Shot 2020-07-06 at 10 26 54 am

The text for "Truncate long option name" and "Selected option always in view" are missing from next to the selection buttons. This occurs both in Firefox and Safari (Firefox on top, Safari below with different screen sizes). If I change the screen size, it still doesn't show up.

There is an error that comes up with the first card selection as well as when I choose the 'Custom: Select List Card' which is

TypeError: t.path is undefined select-list-card.js:280:123

Additional information:

kuchel77 avatar Jul 06 '20 00:07 kuchel77

Thank you for the bug report.

I don't own a mac so hopefully I can borrow one this weekend to reproduce your bug. On windows Firefox(78.0.1) the text appears just fine, I used the default <ha-switch> component for the toggles so its weird why text doesn't show. Do you have any other custom cards with toggles in the editor, so you can confirm it's only broken in my card?

The TypeError seems to be unrelated, I have a better solution for getting the path now so I'll make a new release today.

mattieha avatar Jul 07 '20 14:07 mattieha

I just released v1.1.1 please update the card via hacs and let me know if this fixes the TypeError.

mattieha avatar Jul 07 '20 15:07 mattieha

Checklist:

  • [x] I updated to the latest version available
  • [x] I cleared the cache of my browser

Release with the issue: v1.0.0 Last working release (if known):

Browser and Operating System:

Firefox (77.0.1) and Safari (v??) on MacOS Catalina

Description of problem: Screen Shot 2020-07-06 at 10 15 23 am Screen Shot 2020-07-06 at 10 26 54 am

The text for "Truncate long option name" and "Selected option always in view" are missing from next to the selection buttons. This occurs both in Firefox and Safari (Firefox on top, Safari below with different screen sizes). If I change the screen size, it still doesn't show up.

There is an error that comes up with the first card selection as well as when I choose the 'Custom: Select List Card' which is

TypeError: t.path is undefined select-list-card.js:280:123

Additional information:

Same Here, also with Firefox.

Aantekening 2020-07-07 230114

willsmarthome avatar Jul 07 '20 21:07 willsmarthome

Same issue still unfortunately. I check on Firefox with a disabled cache to make sure I was getting the latest version, as well as Chrome, which I haven't used previously with this instance of Home Assistant, and still the same issue. I also tested on a Windows PC with both Firefox and Chrome and it also shows the same.

When I have a look at the source, it seems that the label is there, but it isn't displaying for some reason.

The path error is no longer appearing using 1.1.1.

kuchel77 avatar Jul 08 '20 00:07 kuchel77

Same error here, missing descriptions (Firefox/Ubuntu). Could it be because our locale is not English, and the card config is trying to load the corresponding locale but doesn't find it?

nagyrobi avatar Jul 18 '20 11:07 nagyrobi

First of all my apologies for the late response: work and holidays.

Apparently there has been some changes in the HA frontend code since 0.112.0 which I only upgraded too. That's why i couldn't reproduce the bug you all have been reporting. I'm still figuring out why it happens and how to correctly use the ha-switch component, since there isn't any documentation for it.

For now I have made a fix which places the label outside toggle button. The label is now showing, although it's not clickable, so you have to click the toggle itself.

Please update to v1.2.0 and let me know if this fixes the problem.

mattieha avatar Jul 20 '20 14:07 mattieha

Thanks. Now for me (at least in Hungarian) the first and the third switch have the same text: kép

nagyrobi avatar Jul 20 '20 20:07 nagyrobi

You're right, I copied the localize string and forgot to change it.

I'll release a bug fix tomorrow, thanks for letting me know!

mattieha avatar Jul 21 '20 16:07 mattieha