ExifReader icon indicating copy to clipboard operation
ExifReader copied to clipboard

Published 20 hours ago • verified publisher icon mattiasw

Fix XmpTag type

Open suke opened this issue 2 years ago • 2 comments

Description

Hi,

I changed XmpTag['value'] type from intersection types to union types. It is the expected behavior to be one of the types.

Current behavior Screen Shot 2022-07-04 at 18 42 15

Expected behavior Screen Shot 2022-07-04 at 18 43 24

suke avatar Jul 04 '22 10:07 suke

This is a great change. Thanks for that! Narrowing a type is often considered a breaking change though and needs a major version bump so I'm a bit hesitant to just merge this right away. Most people still haven't upgraded to version 4 even though the last 3.x version is more than a year old now. I will merge this but I will probably wait a while first and see if there are any more breaking changes that can be included at the same time.

mattiasw avatar Jul 04 '22 11:07 mattiasw

Thanks for the quick response. I'm not in a hurry, so anytime is fine for release!

suke avatar Jul 04 '22 14:07 suke

When thinking about this some more it's a bug and the fix should be released as such. :-) Released in version 4.9.2.

mattiasw avatar Feb 26 '23 17:02 mattiasw