Matthias Bertschy
Matthias Bertschy
@ehashman could you please review the KEP when possible, since you seem to [be the official reviewer](https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/). Thanks!
Thanks @adisky !
@ehashman thanks for your review. I have addressed most of your comments, I'm just waiting for @adisky to give me write access to her branch to push.
> @ehashman thanks for your review. I have addressed most of your comments, I'm just waiting for @adisky to give me write access to her branch to push. @ehashman done
Hmm, looks like I have to tweak `func checkUnknownFields` for the `RawMessage` parts...
I am not sure it's possible to generate types at runtime in Go... I did try several approaches, but that one had the benefit of using generic methods for the...
But this is a bit against what @cjwagner was saying here: https://github.com/kubernetes/test-infra/issues/9757#issuecomment-428647392 Should we ask him?
Thanks, I will try my best :)
@cjwagner one question though... what type should I put in `config.go` for `Approve`? This is the same issue I had faced before falling back to rawMessage. If I put `ConfigTree`...