zsh-sdkman icon indicating copy to clipboard operation
zsh-sdkman copied to clipboard

Make plugin compatible with macos or restrict it just to linux distro

Open Marek00Malik opened this issue 5 years ago • 4 comments

Hello, I ran into a problem with SED when executing the sdk-refresh-completion-files command on MacOs (10.14.5). This is the following error I'm getting:

➜ ~ sdk-refresh-completion-files sed: illegal option -- r usage: sed script [-Ealn] [-i extension] [file ...]

From what I know sed is a bit different for Mac because of the BSD difference. Could you change the usage of sed to grep or any other text tool that would be compatible with OSX and Linux ?

Marek00Malik avatar Jun 04 '19 09:06 Marek00Malik

Hello,

I don't have a lot of time right now to take a look at this. However I'll try as soon as I can (Maybe this week-end). If you come across a fix, don't hesitate to fork and PR !

Thanks for the heads-up.

matthieusb avatar Jun 04 '19 10:06 matthieusb

HI.

I have released a new version you can use to correct the sed -r error. However there might be other problems with sed expressions, so i am not sure if this is completely corrected.

Tell me if this fixes you problem. Don't hesitate to give me some more feedback on this issue and I'll try to correct them along the way.

Thanks in advance.

matthieusb avatar Jun 10 '19 13:06 matthieusb

Has your problem been fixed ?

matthieusb avatar Oct 28 '19 11:10 matthieusb

Hello, did my update fix your problem ?

matthieusb avatar Dec 08 '19 18:12 matthieusb