sass-css3-mixins icon indicating copy to clipboard operation
sass-css3-mixins copied to clipboard

some ideas and notes

Open akurfuerst opened this issue 10 years ago • 0 comments

Hey,

this is not really an issue, but some ideas and questions while reading your scss code

  1. what is the advantage of this mixins instead of using "normal" css? @mixin text-shadow($x: 2px, $y: 2px, $blur: 5px, $color: rgba(0,0,0,.4)) { text-shadow: $x $y $blur $color; }
  2. i think the $r, $g, $b vars are to much, you can transform the normal hexcode color to rgb or rgba with background: rgba($color, $opacity);

@mixin box-rgba($r: 60, $g: 3, $b: 12, $opacity: 0.23, $color: #3C3C3C)

  1. i also think the font-face mixins has too much parameters. i think its better, when you rename all the fonts with their types to the same name.

e.g. you have arial as webfont, so rename alle the types to the same name (arial.ttf, arial,woff, arial.eot, ...)

@mixin font-face($fontFamily: myFont, $eotFileSrc: 'myFont.eot', $woffFileSrc: 'myFont.woff', $ttfFileSrc: 'myFont.ttf')

so you can have just one src file

and make it like this: src: url('webfonts/#{$file}.eot'), url('webfonts/#{$file}.woff') format('woff'),

and so one. Maybe you should add the font-weight as a new parameter.

I hope this is helpful for you.

akurfuerst avatar Nov 27 '14 10:11 akurfuerst