Matthias Rohmer

Results 63 comments of Matthias Rohmer

Haven't had a detailed look yet, but it might be worth looking at https://github.com/GoogleChrome/web.dev/pull/7177/files#diff-747808994e25221313c98080756bef4444f8969dda0b2ff1ae3a4ed39e27cde8R90 which tries to implement the same for web.dev and seems to handle a lot of the...

This is now ready for review.

Will add additional tests after https://github.com/GoogleChrome/developer.chrome.com/pull/3783 landed. But also this one here should probably sit till after the summit to not cause any irritations next week and being able to...

Yep! Now that https://github.com/GoogleChrome/developer.chrome.com/pull/3783 is in I will quickly add some additional tests, then this is good to go 🙂

Added tests and an entry to the handbook.

CSP headers should also go per route to prevent bloating headers with nonces for scripts not used on every page. For web.dev we ship roughly 2.8KB of CSP headers for...

Thanks for reporting! We'll consider adding a hover effect for the social links on the author pages. We do not offer options in the language dropdown if the page is...

The social media links are currently made up of utility classes. So there unfortunately is no existing component where you could just add a `:hover` rule.

You're welcome! I can also take care of updating the other things tomorrow now the keys are valid again 🙂

Hm. The redundancy is needed to have actual documents in the correct collections so Grow can render them in the navigation sidebars. But as their automatically created when the files...