minify icon indicating copy to clipboard operation
minify copied to clipboard

It looks like the minify isn't catching // comments

Open RichardTMiles opened this issue 6 years ago • 5 comments

The minify is compressing my files and inlining my "//" comments causing code to be read as comments..

RichardTMiles avatar Feb 10 '19 18:02 RichardTMiles

You can use /* Type Here */ type comments.

MDReal32 avatar Feb 11 '19 06:02 MDReal32

In sublime it with hotkey CTRL + SHIFT + /

MDReal32 avatar Feb 11 '19 06:02 MDReal32

I wish It was that simple... I'm not trying to re-comment all of my dependancies code. That would be a bad solution for a long term goal. I tested the latest branch as well as the current stable and got bad results. I ended up using a diffrent repo for the JS minify section of my codebase. The repo is :: "patchwork/jsqueeze": "^2.0"

I hope this helps you fix the mistake here. I no longer need help resolving this issue.. You can mark it resolved whenever you feel like.

RichardTMiles avatar Feb 16 '19 00:02 RichardTMiles

I tried to use this library and noticed that issue.

It's surprising your minifier updated just a couple of months ago does not handle this task while jsqeeze does it and the last commit was made in 2016.

Digitalone1 avatar Feb 12 '21 11:02 Digitalone1

I tried to use this library and noticed that issue.

It's surprising your minifier updated just a couple of months ago does not handle this task while jsqeeze does it and the last commit was made in 2016.

Note in my experience jsqeeze may need manual semicolons appended to each file after file_get_contests

RichardTMiles avatar Feb 14 '21 05:02 RichardTMiles