Matthias Fabry
Matthias Fabry
I created a fresh conda environment with: `conda create -n pymayavi python=3.7 vtk=8 pyqt=5` then `conda activate pymayavi` `conda install mayavi` This creates an environment with: ``` $ conda list:...
When doing wind-mass transfer with accretion_j_dot, in the case when the direction of mass transfer changes, the accretor does not have its accreted_material_j set. This makes solve_omega_mix fail as j(k)...
Currently, `libphoebe.mesh_radiosity_problem_nbody_convex()` was called each iteration, leading to un-needed slowdown. I've overridden the appropriate properties of `Envelope` so this does not happen. In the current implementation of contact envelopes, I...
Implements parametric contact-binary energy transfer. 4 schemes are currently supported: 1. Simple smoothing of the neck temperatures to avoid discontinuities (implemented by @aprsa, @gecheline) 2. Isotropic mixing where the temperatures...
When modeling high-mass-ratio contact binaries, usually a high `ntriangles` is needed to accurately represent the small secondary component (and the neck region). However, using a single `ntriangles` over-samples the large...
Phoebe segfaults in the `mesh_radiosity_problem_nbody_convex` when selecting no distortion. MWE: ```python import phoebe as p lggr = p.logger() b = p.default_binary() b.add_dataset('lc', compute_phases=p.linspace(-0.5, 0.5, 50)) b.set_value_all('distortion_method', 'none') b.run_compute() ``` stack...
Starting from the `ld_coeffs` fitting tutorial, switching to the differential evolution solver fails due to incorrect bounds being passed to `scipy` ``` import phoebe import numpy as np logger =...
Starting from the `ld_coeffs` fitting tutorial, changing the solver to `dc` fails solver checks: ``` import phoebe import numpy as np logger = phoebe.logger('error') import matplotlib.pyplot as plt plt.switch_backend('tkagg') #%%...