w2w icon indicating copy to clipboard operation
w2w copied to clipboard

fix spaces in user-defined ucp lookup table

Open matthiasdemuzere opened this issue 2 years ago • 2 comments

Addressing the white spaces in column names of user-defined LCZ look-up table. See #92

matthiasdemuzere avatar Sep 22 '22 13:09 matthiasdemuzere

I have added a small check to see whether the custom MH_URB2D_MIN (MH_URB2D_MAX) values are smaller (larger) than MH_URB2D. Which is needed to calculate the building height distribution with scipy.stats.truncnorm.

This integrity check is only executed when a custom ucp table is provided.

matthiasdemuzere avatar Sep 22 '22 13:09 matthiasdemuzere

I just added a test for this and found a very minor bug. The name of the index becomes something like this ' ' where it should be None. I don't think this is relevant for us, but not sure if we can/should just ignore it.

jkittner avatar Sep 30 '22 16:09 jkittner

Just wondering @theendlessriver13, are you still working on this? As far as I can see, the test is failing?

matthiasdemuzere avatar Nov 03 '22 08:11 matthiasdemuzere

I just added a test for this and found a very minor bug. The name of the index becomes something like this ' ' where it should be None. I don't think this is relevant for us, but not sure if we can/should just ignore it.

This is still the question because the Implementation is not 100% correct, that's why the new test fails.

jkittner avatar Nov 03 '22 12:11 jkittner

I see... so I will have to check my implementation. Will add to my todo list ...

matthiasdemuzere avatar Nov 04 '22 19:11 matthiasdemuzere

This fixes this small (irrelevant) mismatch between the dataframes! @theendlessriver13

matthiasdemuzere avatar Nov 09 '22 13:11 matthiasdemuzere