flaxmodels icon indicating copy to clipboard operation
flaxmodels copied to clipboard

Possible bug in StyleGAN training code

Open wilson1yan opened this issue 2 years ago • 1 comments

Hi,

Nice repo! Is this line a bug? Since I think batch['images'] is N x B x H x W x C, so the indices should be shift up by 1.

https://github.com/matthias-wright/flaxmodels/blob/edc6a8571a6d7202bd9f3bc9241221405c083fd4/training/stylegan2/training.py#L239

wilson1yan avatar Oct 30 '22 01:10 wilson1yan

Hi @wilson1yan, sorry for the late reply! I think you are right, do you want to submit a PR?

matthias-wright avatar Nov 10 '22 09:11 matthias-wright