Locksmith icon indicating copy to clipboard operation
Locksmith copied to clipboard

Swift 5.0 compatibility

Open taraspasichnyk opened this issue 5 years ago • 8 comments

Are you planning to update codebase?

taraspasichnyk avatar Mar 27 '19 09:03 taraspasichnyk

Hi Team,

I am having a trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2

When you guys are planning to update codebase. @matthewpalmer @victor @jonallured @hermanolsson @jakemarsh @diejmon @marcelofabri @edwellbrook @larslockefeer

MayankAgarwal04 avatar Mar 29 '19 13:03 MayankAgarwal04

updated Xcode and it converted my codebase to Swift 5.0 compulsively 😫. Now I need Locksmith in 5.0 😤

mromanuk avatar Apr 04 '19 16:04 mromanuk

Just submitted a Pull Request to address this, hope some of the admins see it

mromanuk avatar Apr 04 '19 16:04 mromanuk

Is this repository deprecated?

pableiros avatar May 21 '19 23:05 pableiros

same issue for me too. any solution please?

lohithkorp avatar May 31 '19 13:05 lohithkorp

my issue is same as @MayankAgarwal04 Trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2 - Swift 5

lohithkorp avatar May 31 '19 14:05 lohithkorp

sorry, I messed up, my comment was for a different project.

  1. Use it with PR
  2. use my fork
  3. download it yourself and put Swift 5.0 instead of 4.x

EDIT: I'm using my own fork, which just address the flag that it should compile with Swift 5.0 (it works)

mromanuk avatar May 31 '19 14:05 mromanuk

swift 5 upgraded, all tests passed check this out https://github.com/stephanheilner/Locksmith

abdullah-s avatar Jul 11 '19 01:07 abdullah-s