Locksmith icon indicating copy to clipboard operation
Locksmith copied to clipboard

Convert to Swift 4.2

Open benlachman opened this issue 6 years ago • 5 comments

Simple conversion from 4.0 to 4.2 along with project file updates and the removal of unused pod config files referenced from Xcode.

benlachman avatar Nov 06 '18 18:11 benlachman

@benlachman looks like the CI tests are failing:

❌  “Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

tc avatar Dec 16 '18 22:12 tc

What is the reason Travis is failing? Can we get this fixed?

DmitryPR avatar Jan 16 '19 11:01 DmitryPR

You probably need to change osx_image to xcode10.1 in .travis.yml file, to see if this PR actually passes the tests.

gcharita avatar Jan 16 '19 15:01 gcharita

Any news ?

grifas avatar Feb 04 '19 14:02 grifas

Created a separate PR with this fix and travis fix not sure who can review it

DmitryPR avatar Feb 04 '19 14:02 DmitryPR