haunted icon indicating copy to clipboard operation
haunted copied to clipboard

IE11 support is broken (even with proxy polyfill)

Open scttdavs opened this issue 6 years ago • 8 comments

Love the library so far! We support IE11 for now, so I was trying this out and it looks like a change 5 months ago broke support for IE11, even with the proxy polyfill. The polyfill does not support getPrototypeOf: https://github.com/GoogleChrome/proxy-polyfill/blob/f4e1a0651833b0e93e016c4e1a511171d973f9b4/src/proxy.js#L52

This PR is where it broke: https://github.com/matthewp/haunted/pull/128

scttdavs avatar Jan 13 '20 19:01 scttdavs

we are having the same problem. We are building a component library that should support IE11 too.

I like very much haunted, so I tried to make a PoC and build an hello world with haunted and lit-element.

Even if I like the haunted approach with react-like hooks, I haven't been able to make it work on IE11, while lit-element is currently working with the build configuration I wrote in the PoC project.

Do you see anything wrong with my code? Could you please give us some hints about how to solve it, or it's just not feasible?

Thanks

lsimone avatar Jan 23 '20 18:01 lsimone

Same to me, not working in IE11

CKGrafico avatar Jan 12 '21 08:01 CKGrafico

@matthewp sorry but do you have some news or suggestions about how to solve this?

CKGrafico avatar Jan 25 '21 11:01 CKGrafico

I'd accept a PR that conditionally adds that proxy trap only in supported browsers.

matthewp avatar Jan 31 '21 12:01 matthewp

Yes sounds good, but can you confirm that this is a bug, and your readme is not ok? becuase maybe everything works to you and there is another problem.

CKGrafico avatar Feb 01 '21 09:02 CKGrafico

FYI: as a temp fix you can comment getPrototypeOf from the lib and your project will work

CKGrafico avatar Feb 01 '21 21:02 CKGrafico

Not sure what you mean. This project has never officially supported IE11. Some contributors discovered a way to get it to work and they documented it via the readme. I'm willing to make small changes such as this one to get it to continue to work but if it comes to the point where we have to dramatically do things differently to support IE11 then we'll just drop support.

matthewp avatar Feb 02 '21 13:02 matthewp

For sure :) the only change right now is the getPrototypeOf you'll need to decide if is enough important or not

CKGrafico avatar Feb 02 '21 13:02 CKGrafico