custom-attributes icon indicating copy to clipboard operation
custom-attributes copied to clipboard
verified publisher icon matthewp

Fix bug that caused changedCallback to fire instead of disconnectedCallback

Open trusktr opened this issue 8 years ago • 7 comments

This also prevents from modifying the custom attribute's this.value when disconnected, so that the old value can be used in the disconnected logic (because the value wasn't changed, the attribute was removed).

trusktr avatar Oct 24 '17 22:10 trusktr

Anything I should add to tests?

trusktr avatar Oct 24 '17 22:10 trusktr

Oops, realized I changed the wrong file. Let me edit...

trusktr avatar Oct 25 '17 00:10 trusktr

Alright, updated.

trusktr avatar Oct 25 '17 00:10 trusktr

Thanks! I'll probably add a test to this before merging.

matthewp avatar Oct 25 '17 01:10 matthewp

Woops, closed by mistake.

matthewp avatar Oct 25 '17 01:10 matthewp

I'll add a test soon...

trusktr avatar Aug 05 '19 07:08 trusktr

I need to circle back to this! Putting it on my Todo list this time.

trusktr avatar Jul 07 '20 01:07 trusktr