Matthew Phillips

Results 617 comments of Matthew Phillips

Needed for https://github.com/bitovi/steal-tools/issues/179

the filenames not being distinct makes it harder to search is my only issue.

Looking at the code it appears that that library doesn't prevent the request from occurring. I think it's for modifying requests/responses, as a sort of aspect-oriented programming mechanism. But the...

I don't understand the issue. Are you saying that it *can't* be turned off? Or are you saying that it can be, but it shouldn't?

https://github.com/canjs/can-fixture/blob/c67816b167730f7002a9db03a92cde483cdbf130/fixture.js#L70 is where this happens. I don't recall the historical reason for adding it. So I'm not sure if it's a breaking change to remove it or not.

There's an existing signature where the 2nd arg is an object.

I'm guessing that `combineRequests` is a different thing in 2 and 3, right? Because I'm pretty sure the APIs are different. So those would be imported from different places. Anyways,...

I created a test for this in cffff6d7d1725ea0481940447879160e6b49550d and it passes. There's some context that I'm missing I think.

I think there's a bug here, I just haven't been able to recreate it in a test. method vs. type doesn't matter, i've tried both.