astro-fastify icon indicating copy to clipboard operation
astro-fastify copied to clipboard

bugfix: socket + post with data

Open AceCodePt opened this issue 1 year ago • 3 comments

Hi!

Found 2 problems:

  1. making POST requests to pages with data (in any non empty format) doesn't return.
  2. When using the @fastify/websocket, the vite websocket runs partially on fastify.

Fixed them.

However: With these changes.,only the requests that were explicit towards fastify will be caught, unlike the previous version where all was caught.

Upside: I believe this is slightly faster then the previous algorithm, because we are dividing only for relevancy.

AceCodePt avatar Feb 21 '24 21:02 AceCodePt

@matthewp It doesn't support all the ways to encode information, but it is a nice start. Waiting on you mate :)

AceCodePt avatar Feb 29 '24 20:02 AceCodePt

I need this fix for a project that I am working on, just to add an additional data-point. These changes work for my situation.

tdnordine avatar Mar 04 '24 14:03 tdnordine

I need this fix for a project that I am working on, just to add an additional data-point. These changes work for my situation.

for the mean while: @tdnordine pnpm i AceCodePt/astro-fastify#bugfix/websocket-post-data

AceCodePt avatar Mar 04 '24 14:03 AceCodePt