Matthew O'Riordan

Results 210 comments of Matthew O'Riordan

Well yes, I couldn't agree more, hence the issue and https://github.com/ably/docs/issues/252. I think the logic should be quite simple: * Sync methods always throw exceptions * Async methods / methods...

New instance of what a customer considers to be a "crash". We have not manually closed the library, but we're seeing crashes with this trace: ``` io.ably.lib.types.AblyException$HostFailedException: java.lang.Exception: Connection unavailable...

Well in Ruby, I follow the policy that: * 40x-like errors that are invalid because the inputs are incorrect, and can be determined by the library regardless of the state...

FYI, an overly simple implementation is included in the Ably Ruby lib - see https://github.com/ably/ably-ruby/blob/master/lib/ably/realtime/channel.rb#L50-L51. This does not factor in message size or allow defaults to be changed so is...

Given at present Travis does not support Ruby on Windows https://docs.travis-ci.com/user/reference/windows/, it's unlikely we can fix this in the near future.

For this particular issue the recommendations here is to run a local web server in the test and not to stub out the request. I am on mobile now so...

@paddybyers I don't want to fix this until we have agreed on https://github.com/ably/realtime/issues/1851. Can you confirm what the final stats structure is for push and I will update this PR?

See https://github.com/ably/ably-ruby/pull/148/commits/a31f8b41f1b933d3d2b4f6a704293257780024ee and https://github.com/ably/ably-ruby/pull/148/commits/7f58488744e68f2cd96d21386c81df1274afc37d for notes on style

See #149 Result: ``` 188 files inspected, 6703 offenses detected ``` Sadly we have other priorities

@SimonWoolf did you close this because of my feedback about issues relating to new attributes needing to be explicitly added? If so, I expect there are places we could check...