capybara-screenshot icon indicating copy to clipboard operation
capybara-screenshot copied to clipboard

Published 20 hours ago • verified publisher icon mattheworiordan

Add Appraisal gemset for Capybara 2 and 3

Open mattheworiordan opened this issue 7 years ago • 5 comments

See https://github.com/mattheworiordan/capybara-screenshot/pull/236#pullrequestreview-166802421 for backgruond.

mattheworiordan avatar Oct 21 '18 21:10 mattheworiordan

I also see the warning: capybara-screenshot could not detect a screenshot driver for 'apparition'. Saving with default with unknown results. The screenshot itself looks really well, thought.

Gems:

  • apparition (0.2.0)
  • capybara (3.20.2)
  • capybara-screenshot (1.0.22)

eiapopeia avatar May 23 '19 10:05 eiapopeia

I also got that warning when using apparition. Similar to the solution in #22, I've added this to my rails_helper.rb and it seems to work: Capybara::Screenshot.register_driver(:apparition, &:save_screenshot).

sedubois avatar May 24 '19 11:05 sedubois

Thanks for the hint. This fixes the message for me.

I think it should be already built in because apparition driver will be the default in the future.

eiapopeia avatar May 24 '19 12:05 eiapopeia

@eiapopeia @sedubois sorry for the slow reply on this. I agree apparition is likely to win the battle here. Would either of you be willing to do a PR with my help?

mattheworiordan avatar Jun 10 '19 21:06 mattheworiordan

See https://github.com/mattheworiordan/capybara-screenshot/pull/219/files for a related PR

mattheworiordan avatar Jun 10 '19 21:06 mattheworiordan