component-test icon indicating copy to clipboard operation
component-test copied to clipboard

Published 20 hours ago • verified publisher icon matthewmueller

browser: `component test` should default to `component test browser`

Open jonathanong opened this issue 12 years ago • 6 comments

jonathanong avatar Dec 11 '13 06:12 jonathanong

+1

matthewmueller avatar Dec 11 '13 10:12 matthewmueller

Shouldnt it rather default to phantomjs, to stay on the command line?

Swatinem avatar Dec 11 '13 11:12 Swatinem

I like the idea of getting up and running immediately without any additional dependencies. what about if we do a which phantomjs to test if it's installed, then use that, otherwise use browser?

matthewmueller avatar Dec 11 '13 11:12 matthewmueller

@MatthewMueller yes!

stephenmathieson avatar Dec 11 '13 13:12 stephenmathieson

Sounds fine to me. I just said browser because you can assume everyone has one. As long as it works in happy :)

jonathanong avatar Dec 11 '13 19:12 jonathanong

+1

trevorgerhardt avatar Jan 29 '14 19:01 trevorgerhardt