Matt Mayer

My only concern is that if this is maintained in a seperate project (validatorjs), then any time we need to whitelist a new character for a specific language we need...

Also its not very obvious what letters to allow for different languages. For example do you allow é for `en`? Normally no, but one of the dog breeds in faker.animal.dog...

Also this might catch the case where say an English locale uses a Cyrillic A, but not where a Russian locale uses a Latin A (because you'll certainly have to...

English has many loanwords which keep the diacritics in normal usage say crêpe or naïve or when spelling other country names like Côte d'Ivoire. We shouldn't pretend English is ascii...

https://github.com/faker-js/faker/pull/1520 is another good example. Rather than remove jalapeño we modified code that relied on it to strip accents when they can't be used in ascii contexts.

You could generate some kind of snapshot test, like a dict of all unique characters used in a locale like this, then it would be obvious if new characters were...

Depends on your definition of breaking change. 😀 You could argue that removing the parameter wouldn't be breaking, the docs say it "allows" special characters, not that it guarantees special...

I'm saying i'm pretty sure that anyone who turned this boolean on will quickly regret it as its going to generate email addresses which will fail most validators in an...

See https://github.com/faker-js/faker/actions/runs/4263046776/jobs/7419510093 You can run `pnpm run test` to run the tests locally You can see there are a couple of problems - your JSDoc needs to include `@since` -...

Please paste the output if you get errors and we can help diagnose what the problem is.