Matt Mayer
Matt Mayer
see also discussion at https://github.com/faker-js/faker/issues/465
Bear in mind locales (we want "male" and "female" in different languages) and the need for this to work easily when using vanilla JavaScript as well as typescript.
We do have an open issue for pronouns, if that interests you you can upvote https://github.com/faker-js/faker/issues/1248
I think a new contributor making a pull request should count as 5 upvotes 🤣
without reading the code, i would never have guessed the current implementation.
this seems logical, it could be an option for faker.color.rgb to make "nice" colors. Also TBH if you want "nice" colors nowadays it's way easier to not use RGB but...
Not quite because the faker.color.* etc don't have a way to supply a base color. So I guess that would be needed first.
For reference, some example colors for faker.internet.color (with and without a base color) vs faker.color.rgb: https://stackblitz.com/edit/faker-js-demo-861y3v whether its "aethetically pleasing" is a matter of opinion :)
> Isnt a county an adminstrative area within a state? Not consistently. In the US yes in most states, but you dont write the county in a postal address.
> Team Decision > > We want to keep location.county(). > We should however improve the documentation, that this usually refers to administrative areas within a state: hmm, none of...