Matthew Feickert

Results 721 comments of Matthew Feickert

Seems like maybe a bit of a non-issue given that if a seperate `docs` environment is made with ``` uv pip install --upgrade ".[docs,test]" ``` then things build as expected...

Thanks for the PR :+1:. Please follow the contribution guide (https://github.com/scikit-hep/pyhf/blob/main/CONTRIBUTING.md) in the future. I'm pretty sure this has been discussed in the past, but we can take a look...

@tacaswell this is ready for review now (thanks for merging PR #107).

> I'll sort out the pypi side and merge this in the next week. @tacaswell sounds good and thanks! For the last remaining bit after that in Issue #104 >...

Post PR https://github.com/scikit-hep/pyhf/pull/2623: Validate-PyProject Checks [build-system], [project], [tool.black], [tool.cibuildwheel], [tool.hatch], [tool.maturin], [tool.mypy], [tool.pdm], [tool.poe], [tool.poetry], [tool.pyright], [tool.pytest], [tool.repo-review], [tool.ruff], [tool.scikit-build], [tool.setuptools_scm], [tool.taskipy], [tool.tombi], [tool.tox], [tool.ty], [tool.uv], [tool.setuptools] ?NameDescription ✅ VPP001...

@andrzejnovak This isn't happening with the CMS style? Do you know what specifically in the style sheets is being pulled in to decorate the error bars for `step`?

The linewidth setting for the ATLAS style https://github.com/scikit-hep/mplhep/blob/9b81c76efac31b86575f1c0220104675ed972dac/src/mplhep/styles/atlas.py#L110 was added by @kratsg in https://github.com/scikit-hep/mplhep/pull/239. @kratsg, I think you were just porting the existing ATLAS style stuff from ROOT. Not sure...

The build runs fine, but for reasons unclear to me, during the `test` segment there are multiple `ClobberWarning`s ``` ClobberWarning: This transaction has incompatible packages due to a shared path....

@conda-forge/help-c-cpp, ready for review!