Matthew Draper comments

Results 142 comments of


                                            Matthew Draper

Fix active record insert values of type cast and serialize

While this definitely sounds more correct, I have some worries: 1. We (GitHub) already have existing code that passes pre-`cast` values in here, and at least in one of our...

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

As far as I can see, the expected behaviour is that streaming will set `no-cache` automatically: http://api.rubyonrails.org/classes/ActionController/Streaming.html#module-ActionController::Streaming-label-Middlewares And while AC::Live doesn't seem to document the behaviour, it does likewise: https://github.com/rails/rails/blob/v4.0.0/actionpack/lib/action_controller/metal/live.rb#L41-45

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

Hmmm... can you please create an example that shows the header not getting set? The question of IE8 behaviour seems only tangential. A change to help that doesn't sound eligible...

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

As far as I can see, it would be a bug for either version to fail to set the header, so whichever you can show that behaviour on, would be...

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

Ah okay, that makes sense. So, the workaround would be to use `response.stream.write ""` instead of the initial `response.commit!`. @tenderlove is `commit!` intended to be public API? `sending!` and `sent!`...

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

> Rails live stream is built upon rack.hijack API No, it's not. Though it (probably) eventually should be.

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

`commit!` doesn't mean "send something from the buffer", it means "we've finished building the headers; send them, and move on to a blocking read of the body buffer".

Rack::ETag middleware doesn't play nice with Live streaming when commit! is called before write

@isaiah `rack.hijack` doesn't occur anywhere in the Rails repository. My recollection is that when we tried to make AC::Live use it, we ran into issues. @rosenfeld I'm sure it won't...

Support nested array bind parameter for PostgreSQL parameter.

Recently: https://github.com/rails/rails/pull/47160#issuecomment-1411013539 Previously: https://github.com/rails/rails/pull/36003#issuecomment-519831202 I'd prefer that we look to achieve the `where([:a, :b] => [[1, 2], [3, 4]])` syntax directly, _without_ propagating our existing mishandling of arrays.

Support nested array bind parameter for PostgreSQL parameter.

Yeah we certainly need some way to build such a query more manually... I just have concerns about using nested arrays for that purpose: I don't want to surrender the...