POP-MCAnimate icon indicating copy to clipboard operation
POP-MCAnimate copied to clipboard

Namespace conflicts likely with MCStopProxy stop method

Open pquimby opened this issue 9 years ago • 1 comments

I recently fixed a bug in my codebase caused by having the stop method injected via a category as a part of the MCANIMATE_SHORTHAND define. We have another class from a third-party source with a method name stop. It would be appreciated, since the MCStopProxy category injects into NSObject that is have a more unique name like stopAnimation to avoid any number of other uses of the method name stop.

pquimby avatar Jan 12 '16 19:01 pquimby

That's precisely why MCANIMATE_SHORTHAND exists - it provides convenience at a cost. Your suggestion does have merit though and I'd be happy take a PR :)

matthewcheok avatar Jan 13 '16 15:01 matthewcheok