Matthew Carbone
Matthew Carbone
> 1. Pls change low_symmetry to just skip_symmetry. > 2. Pls add a unittest (in test_sets.py) to test the new argument functionality. @shyuep sure will do. > A note about...
@shyuep just bumping the conversation. I'd like your feedback on what I mentioned in my above comment before I proceed.
@shyuep I'm not sure I agree, but ultimately it's your decision. Before I make any further changes though, can you provide some feedback on my blocking question? >> A note...
@rkingsbury I agree with everything you're saying here. I think though what's most important is that the default settings and behavior be _clearly exposed_ in the documentation. They're currently not,...
@saitcakmak Ah I see. Is this in principle different than if we set the UCB acquisition function `beta` to some large number? I do see it comes from `botorch.acquisition.active_learning`, which...
> I think it is closer in spirit to a look-ahead type acquisition function. Rather than greedily picking the point with the maximum variance, it tries to maximize the reduction...
> I think MaxVar is a bit of a misnomer, since the acquisition function is really just posterior variance at the query point(s). So it should be (q)PosteriorVariance - the...
@eytan sure, it's usually just a baseline, but it's an important one, and sometimes it's good enough.
All, I don't feel comfortable signing Meta's required form to open the PR (given my position it's not entirely obvious that I can, I'm no lawyer and I don't pretend...
@Balandat that is correct. In fact, it actually works with the `Standardize` _output_ transform.