Matthew Birtch

Results 109 comments of Matthew Birtch

> @matthewbirtch The simplest approach is to use the `skuName` from the license to build the text, something like this: > > ![imagen](https://private-user-images.githubusercontent.com/290303/320449353-cd2aea6b-8138-4b15-b55f-6581130b455f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1OTQzOTIsIm5iZiI6MTcxMjU5NDA5MiwicGF0aCI6Ii8yOTAzMDMvMzIwNDQ5MzUzLWNkMmFlYTZiLTgxMzgtNGIxNS1iNTVmLTY1ODExMzBiNDU1Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQwOFQxNjM0NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZjI1MzYzZjU0ZTNjOTY4MDQwMTQ3OWY1MGQ4MDI3NGRhMWVmNWQzOTRlOGExYTA3MzRmNDkxMDM3MDhjNTExJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PfEJpK50upEgmmhdOHza2PhK-jIEsh9VwO2prXd4Zo0) > > That should be shown properly...

@jespino a few changes based on our discussion today: 1. When a custom site name is used on the login screen, it can display below the Mattermost logo. [Figma](https://www.figma.com/file/GF6STPkJkBmyTjTxUAlZ4G/Edition-Labeling?type=design&node-id=4201-28288&mode=design&t=KTfeTz9dG9feO8gJ-4) 3....

@jespino i updated the screenshots in the PR description and also tweaked some CSS on the login page to fix a few minor things (fixes: https://mattermost.atlassian.net/browse/MM-54746)

> @matthewbirtch not blocking for this PR, but there is weirdness where you have to enable custom branding in order to get the custom site name to appear, even though...

I don't think so. The expected result as shown in the description is what I would expect as well. @asaadmahmood might have more context since he was most closely working...

> @matthewbirtch Updated Thanks @raghavaggarwal2308 when you have a moment could provide an updated screenshot?

> @matthewbirtch I have updated the screenshot in the PR description now 👍🏽 Looks good @raghavaggarwal2308, thanks. Is there any way we can truncate the description to be max 3...

> > > @matthewbirtch I have updated the screenshot in the PR description now 👍🏽 > > > > > > Looks good @raghavaggarwal2308, thanks. Is there any way we...

> @matthewbirtch These are the versions for browser compatibility of this property. If these look good to you we can make the change I think we should be good, since...

> @matthewbirtch Updated the CSS Thanks @raghavaggarwal2308. Could you share an updated screenshot again?