Matt Carroll

Results 396 comments of Matt Carroll

I have a few questions. First, do we currently expect scroll offsets to be maintained in `SuperTextField` and `SuperEditor`? If not, can we add a `PageStorage` within each of those...

@angelosilvestre what are the pros/cons of going with page storage vs restoration manager?

How about we go with `PageStore` to solve this problem, and then file an issue that says to consider adding a `restorationId` to `SuperTextField`? We can use both, right?

I don't remember what I had in mind, or whether I had an opinion on saving the scroll offset or not saving it. I suppose it makes more sense to...

Ok. Is that a problem? Are you asking for some kind direction with regard to that? We can generate a page storage key ID internally, right?

Ok, so what's our best option if we don't want to force apps to do something special to avoid this issue?

@angelosilvestre please start with this one by seeing if there are any places where a user can intervene to prevent something from being deleted. I'd be interested to first know...

@miguelcmedeiros @brian-superlist - Do you guys wanna try out this PR and report back with any issues?

@miguelcmedeiros - I addressed your issues. https://github.com/user-attachments/assets/f0733c52-8bfc-4008-a71f-19bf1ae1a2cb Do you want to try out the configurable toolbar builder with tap region ID to make sure you can build the kind of...