Matthew Brett

Results 226 comments of Matthew Brett

Only problematic if the user could easily miss that there's a difference between the two.

Preliminary parser here : https://github.com/matthew-brett/xprotoply Error messages not yet very informative and I need to check over some shift-reduce conflicts, but performance seems pretty good: ``` In [1]: import nibabel.nicom.xprotocol...

Error messages now fairly informative with line and column numbers. Will read a few Siemens files I have to hand. I'm testing with: ``` from __future__ import print_function import sys...

Brendan - any news from your researches?

Any news here? Anything I can do to help?

The lazy loading sounds like a very good idea. Did you have a chance to look at the failing tests? Will you have time to get to cleaning up the...

Hi Brendan. Sorry to be so slow to get to this. What do you think the best way forward here is? I'm afraid I've left a lot of changes to...

Hi Brendan - that's good news. I think I've not done a good job on helping you with this PR - what do you think we should do better from...

More research reveals more pain. There can be many RWVM for each image. https://groups.google.com/d/msg/comp.protocols.dicom/C6kE4X4FvLc/tWPoNvlO3DQJ The mappings apply to ranges of stored (pixel) values, and the ranges can overlap, so more...

Further investigation reasonably reveals that the example image has a RealValueWorldMappingSequence (tag 0040, 9096), with one element. This is therefore the 'Macro' and not the 'SOP'. I am not sure...