pythonwa icon indicating copy to clipboard operation
pythonwa copied to clipboard

Company logo disappears on company update

Open robinchew opened this issue 9 years ago • 10 comments

Happens in production.

robinchew avatar Sep 05 '16 17:09 robinchew

Probably something to do with form.cleaned_data vs request.FILES in create vs update

Mause avatar Sep 05 '16 17:09 Mause

could be because we aren't uploading to S3 - it's only uploading to the local file system on Heroku which is flushed every time the dyno restarts. i can setup the S3 credentials if someone's happy to implement django-storages S3: https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html

mattharley avatar Sep 06 '16 01:09 mattharley

Does it still happen after those changes I made last night?

Mause avatar Sep 06 '16 05:09 Mause

Sorry I haven't deployed yet. You wanna give Mr. Mause deployment permission @mattharley ?

robinchew avatar Sep 06 '16 05:09 robinchew

Just deployed. I think there are 2 problems here.

  1. Just pressing company update button would delete the logo. Now fixed after deploy.
  2. What mattharley's talking about.

robinchew avatar Sep 06 '16 13:09 robinchew

@Mause can you please sign up to Heroku and let me know the email you used so I can then add you as a contributor to the app

Whoever wants to tackle the Amazon S3 upload thingy (shouldn't be too difficult with the examples on the django-storages site) please email and I'll share the access keys with you.

I'm on [email protected]

mattharley avatar Sep 07 '16 04:09 mattharley

I already have a Heroku account under my old psuedonym email address, [email protected]

Mause avatar Sep 07 '16 14:09 Mause

cool added you now

On 7 September 2016 at 22:30, Dominic R. May [email protected] wrote:

I already have a Heroku account under my old psuedonym email address, [email protected]

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mattharley/pdpdmeetup/issues/28#issuecomment-245298926, or mute the thread https://github.com/notifications/unsubscribe-auth/AArt9ItsVSEkn37Su-5ritsCiUMSwR3jks5qnsqcgaJpZM4J1Ott .

Matt Harley

[email protected] mobile: +61 421 933 877 skype: matt.harley

Currently I'm the chief tech guy at hipflask Website/blog: http://www.hipflaskapp.com/ http://www.hipflaskapp.com/ iOS: http://apple.co/12XnhZn Android: http://bit.ly/1plwrbP

mattharley avatar Sep 08 '16 01:09 mattharley

has this been resolved? should some of these old issues be closed?

bendog avatar Jul 30 '18 03:07 bendog

Well since there is no company page anymore. I guess?

robinchew avatar Jul 30 '18 05:07 robinchew