pythonwa icon indicating copy to clipboard operation
pythonwa copied to clipboard

Company Form is missing URL field

Open unixnut opened this issue 8 years ago • 5 comments

Feel free to schedule a Slack chat or Skype/phone call with me to discuss design implications. (I'm enviro_al on Skype.)

unixnut avatar Sep 05 '16 03:09 unixnut

Really just adding a field to the model, and modifying the view code?

:+1:

Mause avatar Sep 05 '16 03:09 Mause

Sounds like you wanna do it @Mause. Go nuts!

robinchew avatar Sep 05 '16 03:09 robinchew

(also, the view code is really over done at the moment. Could easily be rewritten using generic views)

Mause avatar Sep 05 '16 03:09 Mause

It definitely can be refactored, but not a rewrite to class views. I think there is value in having code in the function that shows you what it's actually doing, as opposed to a class view where all the pipe work is hidden away.

robinchew avatar Sep 05 '16 03:09 robinchew

Fair enough, but nevertheless, there is a need for cleanup

Mause avatar Sep 05 '16 03:09 Mause