ansible-consul
ansible-consul copied to clipboard
remove redundant consule CLI flags at consul init script
The flags -bind
and -client
will be overridden with auto generated content from the init script (consul.conf.j2). So you are not able to provide them via configuration.
I think I'm running into the same issue, but I want to confirm.
In the upstart config here, if consul_client_address_bind
is set, the config will automatically use the address of eth0 for the -client
flag.
But if the user sets consul_client_address_bind
AND consul_client_address
here, then the configuration option equivalent of -client
will be set.
Functionally, this means the user cannot set client_addr
, as the flag overrides the config option.
I assume the same is true for the bind
option?
If so, I would propose that when both address
and address_bind
are set, the upstart config do nothing, and let the consul.json
file configure the address. I can/will put this up to a PR, if it sounds good @savagegus
If so, I would propose that when both address and address_bind are set, the upstart config do nothing, and let the consul.json file configure the address. I can/will put this up to a PR, if it sounds good @savagegus
+1 👍
Current config is quite buggy, also due to the hardcoded eth0 iface, see: https://github.com/savagegus/ansible-consul/issues/103#issuecomment-325707696